Skip to content

GH-45798: [C++] Add extension directory to Meson #45799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Mar 14, 2025

Rationale for this change

Continues growing Meson support in Arrow

What changes are included in this PR?

Added the extension directory to the Meson configuration

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #45798 has been automatically assigned in GitHub to PR creator.

Copy link

⚠️ GitHub issue #45798 has no components, please add labels for components.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 14, 2025
@WillAyd WillAyd force-pushed the meson-add-extension-directory branch from 69b157b to ae7bbe7 Compare June 12, 2025 21:08
@WillAyd WillAyd added CI: Extra Run extra CI labels Jun 12, 2025
@WillAyd WillAyd marked this pull request as ready for review June 12, 2025 21:09
@WillAyd WillAyd force-pushed the meson-add-extension-directory branch from ae7bbe7 to eafcea6 Compare June 25, 2025 13:42
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 25, 2025
@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 26, 2025

@kou any chance you can look at this one? Hopefully an easy one to merge in

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit ed13ced into apache:main Jun 27, 2025
46 of 51 checks passed
@kou kou removed the awaiting changes Awaiting changes label Jun 27, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 27, 2025
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ed13ced.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants